On 2017-06-09 22:28:00 +0200, Petr Jelinek wrote: > And here it is, seems better (the 0002 is same as before).
Cool, looks good on a quick scan. > /* Define pathname of exported-snapshot files */ > #define SNAPSHOT_EXPORT_DIR "pg_snapshots" > -#define XactExportFilePath(path, xid, num, suffix) \ > - snprintf(path, sizeof(path), SNAPSHOT_EXPORT_DIR "/%08X-%d%s", \ > - xid, num, suffix) > > -/* Current xact's exported snapshots (a list of Snapshot structs) */ > +/* Structure holding info about exported snapshot. */ > +typedef struct ExportedSnapshot > +{ > + char *snapfile; > + Snapshot snapshot; > +} ExportedSnapshot; > + > +/* Current xact's exported snapshots (a list of ExportedSnapshot structs) */ > static List *exportedSnapshots = NIL; trival quibble: *pointers to Will take care of it over the weekend. Greetings, Andres Freund -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers