On 13 June 2017 at 05:50, Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> wrote: > On Tue, Jun 13, 2017 at 12:03 AM, Dean Rasheed <dean.a.rash...@gmail.com> > wrote: >> My initial thought, looking at the patch, is that it might be better >> to have all the macros in one file to make them easier to maintain. > > Right now the macros are listed just below relkind enum in pg_class.h. > Is that a good place or do you think, we should list them in a > separate file? >
Yeah, I wondered about putting them in a separate file, but I think just below the relkind enum is probably the best place, so that people changing that enum immediately see the first set of related things to be updated. >> Barring objections, I'll push my original patch and work up patches >> for the other couple of issues I found. > > No objections, the patch is good to go as is. Sorry for high-jacking > this thread. > No worries. I missed that other thread initially, so it was useful to link the 2 threads together. Regards, Dean -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
