On 2017-06-22 08:46:35 +0900, Michael Paquier wrote: > On Thu, Jun 22, 2017 at 4:16 AM, Peter Eisentraut <pete...@gmx.net> wrote: > > Restart logical replication launcher when killed > > - /* The logical replication launcher can be stopped at any time. */ > - proc_exit(0); > + /* The logical replication launcher can be stopped at any time. > + * Use exit status 1 so the background worker is restarted. */ > + proc_exit(1); > I know I am noisy on the matter but... This comment format is not PG-like.
That's since been repaired by the new pgindent run. But what I'm a bit confused about is why we're going for proc_exit() for replication launchers when other types of processes simply FATAL out? Seems like a weird change. It's not like it's not log-worthy if somebody kills the launcher? - Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
