On Thu, Jun 22, 2017 at 2:58 AM, Andres Freund <and...@anarazel.de> wrote:
> One easy way to fix that would be to just wakeup the checkpointer from
> the startup process once at the end of recovery, but it'd not be
> pretty.   I think it'd be better to change the
>                         do_restartpoint = RecoveryInProgress();
>                         /*
>                          * The end-of-recovery checkpoint is a real 
> checkpoint that's
>                          * performed while we're still in recovery.
>                          */
>                         if (flags & CHECKPOINT_END_OF_RECOVERY)
>                                 do_restartpoint = false;
> into having a per-loop 'local_in_recovery' variable, that we turn off
> once a CHECKPOINT_END_OF_RECOVERY checkpoint is requested.
> Comments?

By Initializing this flag out of the for(;;) loop once, this could put
more control into the checkpointer logic so as no new restart points
can be generated after the end-of-recovery checkpoint. This way we
could replace the hack looking for DB_IN_ARCHIVE_RECOVERY in
CreateRestartPoint() by an error handling.

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to