Robert Haas <robertmh...@gmail.com> writes:
> On Wed, Mar 29, 2017 at 11:13 AM, Daniel Gustafsson <dan...@yesql.se> wrote:
>> While reading I noticed that we allow multiple TO <version> in ALTER
>> EXTENSION
>> UPDATE, and defer throwing a syntax error until command processing. Is
>> there a
>> reason for deferring and not handling it in gram.y directly as in the
>> attached
>> patch since it is in fact a syntax error? It yields a different error
>> message
>> to the user, but makes for easier to read code (IMH-and-biased-O).
> I think the idea of the current implementation was probably that the
> grammar should leave room to support multiple options in arbitrary
> order at that point in the syntax. I'm not sure whether that's
> something we'll ever actually need, or not.
It certainly seems plausible to me that we might someday grow additional
options to control the UPDATE, so I'm inclined to reject this patch.
If it were saving a meaningful amount of grammar code, I might think
differently, but it's not really. And it's not like we don't use the
same grammar pattern in lots of other places.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
