On Fri, Jun 23, 2017 at 11:19 AM, Yugo Nagata <nag...@sraoss.co.jp> wrote: > On Fri, 23 Jun 2017 13:41:15 +0900 > Yugo Nagata <nag...@sraoss.co.jp> wrote: > >> On Tue, 6 Jun 2017 13:03:58 +0530 >> amul sul <sula...@gmail.com> wrote: >> >> >> > Updated patch attached. >> >> I looked into the latest patch (v13) and have some comments >> althogh they might be trivial. > > One more comment: > > + if (spec->remainder < 0) > + ereport(ERROR, > + (errcode(ERRCODE_INVALID_TABLE_DEFINITION), > + errmsg("remainder for hash partition must be a > non-negative integer"))); > > The value of remainder is defined as Iconst in gram.y, so it never be > negative. > Hence, I think this check is not necessary or Assert is enough. > Make sense, fixed this as well in the v14 patch. Thanks again.
Regards, Amul -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers