Michael Paquier wrote: > On Thu, Jul 20, 2017 at 4:04 PM, Alvaro Herrera > <alvhe...@2ndquadrant.com> wrote: > > I think the addition of checks everywhere for NULL return is worse. > > Let's add a missing_ok flag instead, so that most callers can just trust > > that they get a non null value if they don't want to deal with that > > case. > > If you want to minimize the diffs or such a patch, we could as well > have an extended version of those APIs. I don't think that for the > addition of one argument like a missing_ok that's the way to go, but > some people may like that to make this patch less intrusive.
I think minimizing API churn is worthwhile in some cases but not all. These functions seem fringe enough that not having an API-compatible version is unnecessary. But that's just my opinion. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers