Hello Tatsuo-san,
I found an error message in pgbench is quite confusing.
pgbench -S -M extended -c 1 -T 30 test
query mode (-M) should be specified before any transaction scripts (-f or -b)
Since there's no -f or -b option is specified, users will be
confused.
Indeed.
Actually the error occurs because pgbench implicitly introduces a built
in script for -S. To eliminate the confusion, I think the error message
should be fixed like this:
The idea is that -S/-N documentations say that it is just a shortcut for
-b, but the explanation (eg --help) is too far away.
query mode (-M) should be specified before transaction type (-S or -N)
or any transaction scripts (-f or -b)
I would suggest to make it even shorter, see attached:
query mode (-M) should be specified before any transaction scripts (-f,
-b, -S or -N).
I'm wondering whether it could/should be "any transaction script". My
English level does not allow to decide.
--
Fabien.
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
index 4d364a1..9e41c07 100644
--- a/src/bin/pgbench/pgbench.c
+++ b/src/bin/pgbench/pgbench.c
@@ -3898,7 +3898,7 @@ main(int argc, char **argv)
benchmarking_option_set = true;
if (num_scripts > 0)
{
- fprintf(stderr, "query mode (-M) should be specified before any transaction scripts (-f or -b)\n");
+ fprintf(stderr, "query mode (-M) should be specified before any transaction scripts (-f, -b, -S or -N)\n");
exit(1);
}
for (querymode = 0; querymode < NUM_QUERYMODE; querymode++)
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
