On Mon, Aug 7, 2017 at 9:38 PM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > On Mon, Aug 7, 2017 at 7:19 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: >> On Mon, Aug 7, 2017 at 6:07 PM, Ashutosh Sharma <ashu.coe...@gmail.com> >> wrote: >>> Hi, >>> >> .. .. >> Why an extra parenthesis in above case whereas not in below case? I >> think the code will look consistent if you follow the same coding >> practice. I suggest don't use it unless you need it. > > That is because in the 1st case, there are multiple operators (*, +) > whereas in the 2nd case we have just one(*). So, just to ensure that > '*' is performed before '+', i had used parenthesis, though it is not > required as '*' has higher precedence than '+'. I have removed the > extra parenthesis and attached is the new version of patch. Thanks. >
Your latest patch looks good to me. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers