On 2017-08-14 13:55:29 -0400, Peter Eisentraut wrote: > On 8/12/17 07:32, Petr Jelinek wrote: > > This commit has side effect that it makes it possible to export > > snapshots on the standbys. This makes it possible to do pg_dump -j on > > standby with consistent snapshot. Here is one line patch (+ doc update) > > which allows doing that when pg_dumping from PG10+. > > > > I also wonder if it should be mentioned in release notes. If the > > attached patch would make it into PG10 it would be no brainer to mention > > it as feature under pg_dump section, but exporting snapshots alone I am > > not sure about. > > Any other opinions on this patch?
I'd be oh so very slightly inclined to push this, including the modified pg_dump check. We're going to be on the hook for supporting snapshots on standbys anyway, unless we put in additional unnecessary error check. - Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers