Hi 2017-08-24 5:50 GMT+02:00 Fabien COELHO <coe...@cri.ensmp.fr>:
> > Hello Pavel, > > I have added the patch to the next commitfest. > > Patch applies, compiles, works. > > I'm okay with the names graw/graw+, and for having such short-hands. > > Missing break in switch, even if last item and useless, because other > items do it... Also should be added at its place in alphabetical order? > I can do > > "column_header" is somehow redundant with "tuples_only". Use the > existing one instead of adding a new one? > It is different - a result of tuples_only is just tuples - not column names, not title, footer. I needed new special flag for enhancing tuples_only to print column names > > More generally, ISTM that the same effect could be achieved without > adding a new print function, but by setting more options (separator, > ...) and calling an existing print function. If so, I think it would > reduce the code size. > Maybe, maybe not. removing PRINT_RAW you need to enhance PRINT_UNALIGNED to use one shot parameters and you have to teach it to print column names in tuples_only mode. The code's length will be same. The form of this patch is not final. > > Missing help entry. > > Missing non regression tests. > > Missing documentation. yes - I wrote it like proof concept - be possible (for me, for others) to verify usability of this commands (and design). I tested it against gnuplot and looks it is works Regards Pavel > > > -- > Fabien. >
