I think the ldap_unbind() changes should be in a separate preliminary patch to be committed separately and backpatched.
The other bits looks fine, with nitpicks 1. please move the new support function to the bottom of the section dedicated to LDAP, and include a prototype 2. please wrap lines longer than 80 chars, other than error message strings. (I don't know why this file plays fast & loose with project-wide line length rules, but I also see no reason to continue doing it.) -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
