On 04.09.2017 23:52, Andres Freund wrote:
Hi. That piece of code isn't particularly clear (and has a bug in the submitted version), I'm revising it.
...
Yea, I've changed that already, although it's currently added earlier, because the alignment is needed before, to access the column correctly. I've also made number of efficiency improvements, primarily to access columns with an absolute offset if all preceding ones are fixed width not null columns - that is quite noticeable performancewise.
Should I wait for new version of your patch or continue review of this code? -- Konstantin Knizhnik Postgres Professional: http://www.postgrespro.com The Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
