On 09/20/2017 06:13 PM, Michael Paquier wrote: > On Thu, Sep 21, 2017 at 7:08 AM, Andrew Dunstan > <andrew.duns...@2ndquadrant.com> wrote: >> First, it warns about a couple of unused variables at lines 4553 and >> 4673 of src/backend/optimizer/path/costsize.c. I think we can do a >> little rearrangement to keep it happy there. > Those are around for some time, see here: > https://www.postgresql.org/message-id/CAB7nPqTkW=b_1jvvywd_g0wrkot+4ufqjggrv8osqbuzzxg...@mail.gmail.com > But there has been no actual agreement about how to fix them..
Oh. Missed that. My solution was going to be slightly different. I was going to enclose the #ifdef'd code in a bare block and move the rte declaration inside that block. I think the difference between these cases and other cases of the PG_USER_FOR_ASSERTS_ONLY macro is that these variables are only even written to by assert-enabled code, whereas in the other cases the variable is written to by non-assert-enabed code but only read by assert-enabled code. The Microsoft compilers don't seem to mind that so much. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
