On 9/21/17 11:46, Tom Lane wrote: > So the code in their git repo still has the variable as bool, but > there's no ++ operator on it anymore. > > This also means that the portability problem is purely hypothetical; > given valid tz reference data the code wouldn't ever try to increment > "hit" to 2 anyway. It's even more hypothetical for us, because we don't > use leap-second-aware zones.
It's not so much that there is an actual portability problem. The problem is that the compiler issues a warning for this with stdbool. > Therefore, what I would like to do is revert this commit (0ec2e908b), > and then either leave the problem to be fixed by our next regular sync > with a released tzcode version, or else force a sync with their git tip > to absorb their fix now. In either case we should keep all our live > branches in sync. I'm willing to do the code-sync work either way. That makes sense. There is no urgency on the stdbool patch set, so waiting for this to be resolved properly around November seems reasonable. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
