On Thu, Sep 21, 2017 at 12:12 PM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: >> Attached patch shows what I'm getting at. This is untested, since I >> don't use Windows. Proceed with caution. > > Your analysis makes sense, but the patch doesn't work, because "locale" > is never set before reading it.
It was just for illustrative purposes. Seems fine to actually move the WIN32 block down to just before the existing TRUST_STRXFRM test, since the locale is going to be cached and then immediately reused where we return immediately (Windows libc) anyway. This would also be a win for clarity, IMV. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers