On Fri, Sep 22, 2017 at 1:52 PM, Schneider <schnei...@ardentperf.com> wrote: > Seems an apt occasion to point out that 10rc1 is missing documentation > for a couple events.
Meh. Thanks for pointing this out. One more. > From src/backend/storage/lmgr/lwlocknames.txt: CLogTruncationLock was > added to the > docs but BackendRandomLock and LogicalRepWorkerLock are missing. (Maybe > there's > a reason for this... I just checked the diffs from 9.6 to 10 then > checked the docs for > completeness.) Indeed, I can see as well that those are the three new ones between 9.6 and 10. Attached is a patch to correct the documentation, I am adding an open item so as this does not fall into oblivion. >> Using this set of meta-data, it is possible to generate the SGMO >> tables and the set of include tables. > > The lock-related events might present a challenge here since they come > from a different > place. In particular, there is no single location to find the > descriptions of tranche locks - you > have to search through the source code and find the > LWLockRegisterTranche() call to see > what text it used for the lock name! (Consolidating that seems like a > great candidate for a > patch...) Perhaps... I did not dig much into the details of this area. I don't recall that it was particularly challenging either to get a base generation in place. -- Michael
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml index 5575c2c837..141a08a08c 100644 --- a/doc/src/sgml/monitoring.sgml +++ b/doc/src/sgml/monitoring.sgml @@ -845,7 +845,7 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser <tbody> <row> - <entry morerows="60"><literal>LWLock</></entry> + <entry morerows="62"><literal>LWLock</></entry> <entry><literal>ShmemIndexLock</></entry> <entry>Waiting to find or allocate space in shared memory.</entry> </row> @@ -1030,6 +1030,14 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser <entry><literal>OldSnapshotTimeMapLock</></entry> <entry>Waiting to read or update old snapshot control information.</entry> </row> + <row> + <entry><literal>BackendRandomLock</></entry> + <entry>Waiting to generate a random number.</entry> + </row> + <row> + <entry><literal>LogicalRepWorkerLock</></entry> + <entry>Waiting for action on logical replication worker to finish.</entry> + </row> <row> <entry><literal>CLogTruncationLock</></entry> <entry>Waiting to truncate the write-ahead log or waiting for write-ahead log truncation to finish.</entry>
-- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers