Hi,
In a case of
initdb /tmp/pgsql
followed by
pg_ctl -D /tmp/pgsql/ -l /tmp/logfile restart
you'll get
pg_ctl: PID file "/tmp/pgsql/postmaster.pid" does not exist
Is server running?
starting server anyway
pg_ctl: could not read file "/tmp/pgsql/postmaster.opts"
The attached patch changes the message to "trying to start server
anyway" to highlight it is an attempt, not something that will happen.
Probably not a good idea to change the logic around pg_ctl.c:688, hence
this suggestion.
Thoughts ?
Best regards,
Jesper
>From 9e8cdda3173a25f1e14cccd7261877f160d1b0f7 Mon Sep 17 00:00:00 2001
From: jesperpedersen <jesper.peder...@redhat.com>
Date: Thu, 28 Sep 2017 15:31:24 -0400
Subject: [PATCH] Change message for restarting a server from a directory
without a PID file. This account for the case where a restart happens after
an initdb
Author: Jesper Pedersen <jesper.peder...@redhat.com>
---
src/bin/pg_ctl/pg_ctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
index 4e02c4cea1..f5281a36a8 100644
--- a/src/bin/pg_ctl/pg_ctl.c
+++ b/src/bin/pg_ctl/pg_ctl.c
@@ -965,7 +965,7 @@ do_restart(void)
write_stderr(_("%s: PID file \"%s\" does not exist\n"),
progname, pid_file);
write_stderr(_("Is server running?\n"));
- write_stderr(_("starting server anyway\n"));
+ write_stderr(_("trying to start server anyway\n"));
do_start();
return;
}
--
2.13.5
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
