Committed and back-patched to v10.  I have to say I'm kind of
surprised that the comment removed by this patch got committed in the
first place.  It's got a ??? in it and isn't very grammatical either.

ISTM that I reviewed the initial patch.

AFAICR I agreed with the comment that whether it was appropriate to go on was unclear, but it did not strike me as obviously a bad idea at the time, so I let it pass. Now it does strike me as a bad idea (tm):-) My English is kind of fuzzy, so I tend not to comment too much on English unless I'm really sure that it is wrong.

Note that there is another 100% cpu pgbench bug, see https://commitfest.postgresql.org/15/1292/, which seems more likely to occur in the wild that this one, but there has been no review of the fix I sent.

--
Fabien.


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to