On 2017-10-11 08:54:10 -0700, Andres Freund wrote: > On 2017-10-11 10:53:56 +0200, Alvaro Herrera wrote: > > Maybe it'd be a good idea to push 0001 with some user of restrict ahead > > of the rest, just to see how older msvc reacts. > > Can do. Not quite sure which older user yet, but I'm sure I can find > something.
I looked around and didn't immedialy see a point where it'd be useful. I don't really want to put it in some place where it's not useful. I think we can just as well wait for the first patch using it to exercise restrict support. There's references to restrict support back to VS 2008: https://msdn.microsoft.com/en-us/library/5ft82fed(v=vs.90).aspx So I'll change the pg_config.h.win32 hunk to: /* Define to the equivalent of the C99 'restrict' keyword, or to nothing if this is not supported. Do not define if restrict is supported directly. */ /* Visual Studio 2008 and upwards */ #if (_MSC_VER >= 1500) /* works for C and C++ in msvc */ #define restrict __restrict #else #define restrict #endif there's several patterns like that (except for the version mapping) in the file already. - Andres -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers