On 10/31/17, Tom Lane <t...@sss.pgh.pa.us> wrote:
> Vitaly Burovoy <vitaly.buro...@gmail.com> writes:
>> Recently my colleagues found a bug.
>> -                                              "SELECT 'bigint'::name AS 
>> sequence_type, "
>> +                                              "SELECT 
>> 'bigint'::pg_catalog.name AS sequence_type,
> Good catch, but I think we could simplify this by just omitting the cast
> altogether:
> -                                               "SELECT 'bigint'::name AS 
> sequence_type, "
> +                                               "SELECT 'bigint' AS 
> sequence_type,
> pg_dump doesn't particularly care whether the column comes back marked
> as 'name' or 'text' or 'unknown'.
>                       regards, tom lane

OK, just for convenience I'm attaching your version of the fix.
I left an other "NULL::name AS rolname" at
src/bin/pg_dump/pg_dump.c:2978 because can't check (remoteVersion <
90000) it and it is under strict "selectSourceSchema(fout,
"pg_catalog");" schema set.

Best regards,
Vitaly Burovoy

Attachment: 0001-Fix-dumping-schema-if-a-table-named-name-exists.ver2.patch
Description: Binary data

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to