Hi all, Thanks Stephen for the suggestion. I wan't thinking globally enough. I was planning to look at it today but Amit was faster. So thanks Amit too!
Have a nice day (UGT), Lætitia 2017-11-01 1:35 GMT+01:00 Amit Langote <langote_amit...@lab.ntt.co.jp>: > On 2017/10/31 21:31, Stephen Frost wrote: > > * Lætitia Avrot (laetitia.av...@gmail.com) wrote: > >> As Amit Langot pointed out, the column_constraint definition is missing > >> whereas it is used in ALTER TABLE synopsis. It can be easily found in > the > >> CREATE TABLE synopsis, but it's not very user friendly. > > > > Thanks, this looks pretty reasonable, but did you happen to look for any > > other keywords in the ALTER TABLE that should really be in ALTER TABLE > > also? > > > > I'm specifically looking at, at least, partition_bound_spec. Maybe you > > could propose an updated patch which addresses that also, and any other > > cases you find? > > Ah, yes. I remember having left out partition_bound_spec simply because I > thought it was kind of how it was supposed to be done, seeing that neither > column_constraint and table_constraint were expanded in the ALTER TABLE's > synopsis. > > It seems that there are indeed a couple of other things that need to be > brought over to ALTER TABLE synopsis including partition_bound_spec. > 9f295c08f877 [1] added table_constraint, but missed to add the description > of index_parameters and exclude_element which are referenced therein. > > Attached find updated version of the Lætitia's patch. > > Thanks, > Amit > > [1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=9f295c >
