On Fri, Nov 3, 2017 at 12:07 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > The patch sent previously does not directly apply on HEAD, and as far > as I can see the last patch set published on > https://www.postgresql.org/message-id/2361ae4a-66b1-c6c5-ea6a-84851a1c0...@postgrespro.ru > has rotten. Could you send a new patch set? > > About the patch set, I had a look at the first patch which is not that > heavy, however it provides zero documentation, close to zero comments, > but adds more than 500 lines of code. I find that a bit hard to give > an opinion on, having commit messages associated to each patch would > be also nice. This way, reviewers can figure what's going out in this > mess and provide feedback. Making things incremental is welcome as > well, for example in the first patch I have a hard way finding out why > timestamps are touched to begin with.
My mistake here, only the first patch adds 8,200 lines of code. This makes the lack of comments and docs even worse. -- Michael -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers