Nigel J. Andrews wrote:
> 
> 
> I never knew running indent was so damn complicated. All three of my
> development systems can not manage it without throughing a fault (I've
> absolutely no idea why indent in the shell works but doesn't in pgindent on
> one).
> 
> Anyway, has anyone pgindented the version of tsearch2 that runs with 7.3.4? If
> so please email it to me. The tar file is tsearch-v2-stable.tar.gz, just for
> clarity and I can supply it if someone volunteers but doesn't have it.

There are about 6 files that can't be run through pgindent, and tsearch2
has one of them:

        $ pgindent *.c
        Hope you installed /src/tools/pgindent/indent.bsd.patch.
        
        gistidx.c
        [EMAIL PROTECTED]: Unbalanced parens
        [EMAIL PROTECTED]: Extra )
        [EMAIL PROTECTED]: Unbalanced parens
        [EMAIL PROTECTED]: Extra )
        [EMAIL PROTECTED]: Unbalanced parens
        [EMAIL PROTECTED]: Extra )
        [EMAIL PROTECTED]: Unbalanced parens
        [EMAIL PROTECTED]: Extra )
        [EMAIL PROTECTED]: Unbalanced parens
        [EMAIL PROTECTED]: Extra )
        [EMAIL PROTECTED]: Unbalanced parens
        [EMAIL PROTECTED]: Extra )
        [EMAIL PROTECTED]: Unbalanced parens
        [EMAIL PROTECTED]: Extra )

It is actually this code that is causing it:

        LOOPBYTE(
                 if ((sign[i] & 0xff) != 0xff)
                 PG_RETURN_POINTER(retval);
        );

With the macro being:

        #define LOOPBYTE(a) \
                for(i=0;i<SIGLEN;i++) {\
                        a;\
                }

If you ask me, this is just _weird_ code and should not be allowed.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  [EMAIL PROTECTED]               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

               http://archives.postgresql.org

Reply via email to