[HACKERS] Broken code in pquery.c

[Tom Lane]

The if() statement at line 418 in pquery.c seems a bit bereft of
controlled statement; looks like a broken log_executor_stats patch.

        if (portal->strategy != PORTAL_MULTI_QUERY)
        {
                ereport(DEBUG3,
                        (errmsg_internal("PortalRun")));
                /* PORTAL_MULTI_QUERY logs its own stats per query */
                if (log_executor_stats)
                        ResetUsage();
        }
        
--->    if (log_executor_stats && portal->strategy != PORTAL_MULTI_QUERY)

        /*
         * Check for improper portal use, and mark portal active.
         */
        if (portal->portalDone)
                ereport(ERROR,
                                (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
                   errmsg("portal \"%s\" cannot be run anymore", portal->name)));

                        regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 8: explain analyze is your friend