People,

In pg_restore --help I see this:

  -O, --no-owner           do not output commands to set object ownership
[...]
  -x, --no-privileges      skip restoration of access privileges (grant/revoke)


Do we talk about "output commands" to do things, or directly about
restoration?  I think -O description should be

  -O, --no-owner           skip restoration of object ownership

or something similar, to be consistent.  Patch for that attached, but
feel free to editorialize ...

-- 
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"The ability to monopolize a planet is insignificant
next to the power of the source"
Index: src/bin/pg_dump/pg_restore.c
===================================================================
RCS file: /home/alvherre/cvs/pgsql/src/bin/pg_dump/pg_restore.c,v
retrieving revision 1.67
diff -c -r1.67 pg_restore.c
*** src/bin/pg_dump/pg_restore.c        27 Nov 2004 18:51:06 -0000      1.67
--- src/bin/pg_dump/pg_restore.c        3 Dec 2004 16:34:50 -0000
***************
*** 376,382 ****
        printf(_("  -I, --index=NAME         restore named index\n"));
        printf(_("  -L, --use-list=FILENAME  use specified table of contents 
for ordering\n"
                         "                           output from this file\n"));
!       printf(_("  -O, --no-owner           do not issue commands to set 
object ownership\n"));
        printf(_("  -P, --function=NAME(args)\n"
                         "                           restore named 
function\n"));
        printf(_("  -s, --schema-only        restore only the schema, no 
data\n"));
--- 376,382 ----
        printf(_("  -I, --index=NAME         restore named index\n"));
        printf(_("  -L, --use-list=FILENAME  use specified table of contents 
for ordering\n"
                         "                           output from this file\n"));
!       printf(_("  -O, --no-owner           skip restoration of object 
ownership\n"));
        printf(_("  -P, --function=NAME(args)\n"
                         "                           restore named 
function\n"));
        printf(_("  -s, --schema-only        restore only the schema, no 
data\n"));
---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]

Reply via email to