On Tue, Jul 05, 2005 at 07:20:48PM -0400, Tom Lane wrote:
> Marko Kreen <[email protected]> writes:
> > Ok Tom, you win. It is indeed possible to make it work, and the
> > resulting makefile is even cleaner than before.
> > Following patch thus autoconfigures pgcrypto. It drops the
> > possibility to use libc's crypt, which was pointless.
>
> Applied with a little extra hacking (completely overriding the original
> values of PG_CPPFLAGS and SHLIB_LINK was unwise, and in fact guaranteed
> to fail on machines where OpenSSL isn't in the default location).
Your PG_CPPFLAGS change does not work - it gets always RAND_SILLY.
If I change it from := to =, make complains about recursion.
--
marko
Index: contrib/pgcrypto/Makefile
===================================================================
RCS file: /opt/arc/cvs2/pgsql/contrib/pgcrypto/Makefile,v
retrieving revision 1.16
diff -u -c -r1.16 Makefile
*** contrib/pgcrypto/Makefile 5 Jul 2005 23:18:44 -0000 1.16
--- contrib/pgcrypto/Makefile 6 Jul 2005 10:37:26 -0000
***************
*** 16,22 ****
CF_TESTS = $(if $(subst no,,$(with_openssl)), $(OSSL_TESTS))
CF_CFLAGS = $(if $(subst no,,$(with_openssl)), $(OSSL_CFLAGS), $(INT_CFLAGS))
! PG_CPPFLAGS := $(CF_CFLAGS) -I$(srcdir) $(PG_CPPFLAGS)
SRCS = pgcrypto.c px.c px-hmac.c px-crypt.c misc.c random.c \
crypt-gensalt.c crypt-blowfish.c crypt-des.c \
--- 16,22 ----
CF_TESTS = $(if $(subst no,,$(with_openssl)), $(OSSL_TESTS))
CF_CFLAGS = $(if $(subst no,,$(with_openssl)), $(OSSL_CFLAGS), $(INT_CFLAGS))
! PG_CPPFLAGS = $(CF_CFLAGS) -I$(srcdir)
SRCS = pgcrypto.c px.c px-hmac.c px-crypt.c misc.c random.c \
crypt-gensalt.c crypt-blowfish.c crypt-des.c \
---------------------------(end of broadcast)---------------------------
TIP 8: explain analyze is your friend
