Tino Wildenhain wrote: > Am Donnerstag, den 21.07.2005, 10:48 -0400 schrieb Tom Lane: > > Another problem with this patch is the search-and-replace substitution > > of "SECS_PER_MINUTE" for "60", when in point of fact there are two > > different meanings of "60" in this context. For instance, this > > code has no problem: > > > > ! int Log_RotationAge = 24 * 60; > > > > but this code looks like it has a units error: > > > > ! int Log_RotationAge = HOURS_PER_DAY * > > SECS_PER_MINUTE; > > > > You need a "MINS_PER_HOUR" or some such if you don't want people > > having to look twice at the code. > > > > BTW, if you actually wanted to improve readability, defining a > > SECS_PER_YEAR value and replacing the various occurrences of > > "36525 * 864" with it would help. > > > IIRC the number of seconds in a year is far from a constant.
Yes, I added a comment mentioning that we don't track leap seconds. And this doesn't handle crossing uneven daylight savings time intervals. Comments updated. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 ---------------------------(end of broadcast)--------------------------- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
