Kris Jurka wrote:
>
>
> On Mon, 24 Apr 2006, Martijn van Oosterhout wrote:
>
> > Perhaps someone could check if changing the test explicitly check
> > against NULL:
> >
> >> ((attnum) > (int) (tup)->t_data->t_natts) ? \
> >> ( \
> >> (((isnull) != NULL)? (*(isnull) = true) : (dummyret)NULL),
> >> \
> >> (Datum)NULL \
> >
> > removes the warning. It seems silly for the GCC people to add warnings
> > for this kind of stuff without a simple way to bypass it...
>
> Yes, this coding removes the warning.
Great, fix attached and applied.
--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Index: src/include/access/heapam.h
===================================================================
RCS file: /cvsroot/pgsql/src/include/access/heapam.h,v
retrieving revision 1.107
diff -c -c -r1.107 heapam.h
*** src/include/access/heapam.h 24 Mar 2006 04:32:13 -0000 1.107
--- src/include/access/heapam.h 24 Apr 2006 22:03:14 -0000
***************
*** 100,106 ****
( \
((attnum) > (int) (tup)->t_data->t_natts) ? \
( \
! ((isnull) ? (*(isnull) = true) :
(dummyret)NULL), \
(Datum)NULL \
) \
: \
--- 100,106 ----
( \
((attnum) > (int) (tup)->t_data->t_natts) ? \
( \
! ((isnull) != NULL) ? (*(isnull) = true) :
(dummyret)NULL), \
(Datum)NULL \
) \
: \
---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend
