Tom: Thanks for the out-of-band posting to the documentation. I think the new version (attached) addresses your issues.

What is the general process for submitting patches? Is there a URL someone can point me towards to learn more?


Josh Reich

Tom Lane wrote:
Joshua Reich <[EMAIL PROTECTED]> writes:
... build a cube by specifying 2 arrays, one for the UR coordinate, one for LL.
I hope people find this useful, and if so, we can add it to contrib/cube.

Seems useful, but it needs work: it will fail on toasted arrays or
arrays containing nulls.  I'd suggest converting it to V1 call protocol
too, as the V1 GETARG macros are the easiest answer to the toasting
problem.  Null array elements are a new issue in CVS HEAD, you'd need
to test against HEAD for that.

As a matter of style, would it be better to error out if the arrays
are not the same length?

                        regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?


#include "postgres.h"
#include "utils/array.h"
#include "cubedata.h"                   /* contrib/cube */
#include "fmgr.h"

**      CREATE OR REPLACE FUNCTION cube_from_arrays(float[], float[]) RETURNS 
**              AS 'cube_from_arrays'
**          LANGUAGE C;

** Taken from the intarray contrib header
#define ARRPTR(x)  ( (double *) ARR_DATA_PTR(x) )
#define ARRNELEMS(x)  ArrayGetNItems( ARR_NDIM(x), ARR_DIMS(x))

** Allows the construction of a cube from 2 float[]'s
cube_from_arrays (PG_FUNCTION_ARGS)
        int             i;
        int             dim;
        int             size;
        NDBOX   *result;
        ArrayType       *ur, *ll;
        double  *dur, *dll;

        if (PG_ARGISNULL(0) || PG_ARGISNULL(1))
                        errmsg("Cannot work with NULL arrays")));

        ur = (ArrayType *) PG_GETARG_VARLENA_P(0);
        ll = (ArrayType *) PG_GETARG_VARLENA_P(1);

        dim = ARRNELEMS(ur);
        if (ARRNELEMS(ll) != dim)
                        errmsg("UR and LL arrays must be of same length")));


        dur = ARRPTR(ur);
        dll = ARRPTR(ll);

        size = offsetof(NDBOX, x[0]) + sizeof(double) * 2 * dim;
        result = (NDBOX *) palloc (size);
        memset (result, 0, size);
        result->size = size;
        result->dim = dim;

        for (i=0; i<dim; i++)
                result->x[i] = dur[i];
                result->x[i+dim] = dll[i];

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
       subscribe-nomail command to [EMAIL PROTECTED] so that your
       message can get through to the mailing list cleanly

Reply via email to