Tom Lane wrote:
Joshua Reich <[EMAIL PROTECTED]> writes:
Do we have an active maintainer of this code?
It sounds like you've just acquired that position ;-)
More than happy to take the role.
How is it reviewed?
Same as everything else, pretty much: patches go to pgsql-patches and
are (supposed to be) reviewed before being committed. If it's in the
nature of a new feature rather than a simple bug fix or code cleanup,
you might want to first start a discussion on pgsql-hackers --- if
anyone has a better idea about how to do things, it's better to find it
out before you start coding instead of after you finish.
Ok. I'll keep changes to a minimum; before I add features, I'll discuss
here.
Because we're relying so heavily on the buildfarm these days, failing
regression tests are quite unacceptable. Adding an ORDER BY might be
the best solution, or maybe you should just change the expected output
--- do you understand exactly why the results changed? As for adding
more tests, you can within reason --- don't make the running time
enormous.
Ok. I'll fix the test cases so that everything is hunky dory.
Josh
---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster