Tom Lane wrote:
Alvaro Herrera <[EMAIL PROTECTED]> writes:
Tom Lane wrote:
It would be interesting to know the actual underlying Windows error code
--- I see that win32error.c maps several different codes to EACCES.


It may be a good idea to put a elog(LOG) with the error code in the
failure path of AllocateFile.

That seems like a plan to me.  I had been thinking of making
win32error.c itself log the conversions, but that would not provide any
context information.  AllocateFile could log the file name along with
the code, which should be enough info to associate a particular log
entry with the actual failure.

Note you should probably save and restore errno around the elog call,
just to be safe.

Could someone with access to Windows code and test this?


All this seems good and sensible.

I am just a little suspicious of seahorse, though, as it is running on a Xen VM.

I wonder if we should add a VM column to the buildfarm machine specs.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Reply via email to