On Thu, Apr 26, 2007 at 01:35:42PM -0400, Tom Lane wrote:
> AFAICS you do not need to inline create_statement.  The risk factor
> is where you call a routine that does something with a va_list, and
> then you want to do something else (other than va_end) with that va_list
> after it returns.  The one use of create_statement doesn't do that,
> hence no problem.  (We know this works, because stringinfo.c does it.)

Given all the problems I had so far with this code I'd prefer to keep it
inlined. :-)

> BTW, I think there is a small bug there: you fail to call va_end() in the
> failure path.  I'm not sure if there are any modern machines where
> va_end() isn't a no-op, but nonetheless the code isn't meeting the spec.

Fixed. Thanks.


Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: [EMAIL PROTECTED]
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?


Reply via email to