On 9/21/07, Tom Lane <[EMAIL PROTECTED]> wrote:
> It shouldn't, though --- the hint bit should get cleared on the first
> try.  I think I probably broke something in the last round of revisions
> to heap_page_prune_opt, but haven't looked yet ...

We set the hint bit (prunable) again when we see a RECENTLY_DEAD
or DELETE_IN_PROGRESS tuple. This is correct in normal circumstances
because otherwise we would never be able to prune the page.

On a second thought, may be we can choose not to set the bit again. In
the worst case, the next update on the page would be a COLD update.
That would set the bit again and we shall retry prune in the next visit to
the page.

This scheme would work as long as we don't put in mechanism to
update FSM after pruning. But if we choose to update FSM (I am
inclined to do this to avoid repeated relation extension because
of COLD updates), we would need to improve this. Otherwise a
page full of only DEAD tuples may never be pruned and vacuum
would be required to reclaim that space.


Pavan Deolasee
EnterpriseDB     http://www.enterprisedb.com

Reply via email to