Andrew Dunstan <[EMAIL PROTECTED]> writes: > I have changed it. The thing is, though, that this function not only > performs the convert() function but acts as the engine for convert_to() > and convert_from(). Those functions do some silent transformations, in > one case passing a text Datum as the first argument and in the other > case the returning the result as text. If there's a better way to do > this I'll be happy to learn, but it seems to me it would involve some > duplication - I tried to avoid that where possible.
Hmm. One suggestion would be to have an internal function declared as taking and returning "struct varlena *", with a comment saying that we depend on text and bytea both being compatible with this. All three SQL-visible functions are then thin wrappers around that. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 2: Don't 'kill -9' the postmaster