"J.R. Nield" <[EMAIL PROTECTED]> writes: > The attached patches against 7.3 and 7.4 fix a subtraction carry bug in > xlog.c.
This is simply a waste of cycles, because xrecoff can never be zero (if it were, it'd be pointing at a page header, which is not a valid record location). If you look around in the code, you'll note that xrecoff==0 is actually used as an invalid-value flag in a couple of contexts. Can you point to anyplace where the behavior would change? If so I think there's a deeper bug to fix. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 7: don't forget to increase your free space map settings