I've committed Aizaz's patch, with some editorial revisions.

Peter Eisentraut <[EMAIL PROTECTED]> writes:
> If the option is named --long-help, I'd expect a longer version of
> --help, which this is not.  The name should probably involve "help"
> and "config" to make it clearer what you get.

I used --help-config.

> The help message should be printed by --help, not -h.  In fact, I
> don't think there should be a separate subhelp message.  Users know
> about --help, and that should give them all information about all
> invocation modes right there.

I didn't do this, because it seemed to involve more coupling between
postgres.c and help_config.c than I thought was good.  But if you're
intent on it, feel free to change it.

> Why are there long explanations in some cases only?  Do you plan to
> add others later?  I also think the messages should be made more
> consistent in various ways, but that can be done later.

I made some small changes for improved consistency but I'm sure
considerably more editing could be done.  Have at it.

                        regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
    (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])

Reply via email to