Lee Kindness <[EMAIL PROTECTED]> writes: > Guys, attached is a patch to fix two memory leaks on start-up.
I do not like the changes to miscinit.c. In the first place, it is not a "memory leak" to do a one-time allocation of state for a proc_exit function. A bigger complaint is that your proposed change introduces fragile coupling between CreateLockFile and its callers, in order to save no resources worth mentioning. More, it introduces an assumption that the globals directoryLockFile and socketLockFile don't change while the postmaster is running. UnlinkLockFile should unlink the file that it was originally told to unlink, regardless of what happens to those globals. If you are intent on spending code to free stuff just before the postmaster exits, a better fix would be for UnlinkLockFile to free its string argument after using it. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html