Tom Lane wrote:
> Bruce Momjian <[EMAIL PROTECTED]> writes:
> > ! #if defined(sun) && defined(__sparc__)
> >     /* use intimate shared memory on SPARC Solaris */
> >     memAddress = shmat(shmid, 0, SHM_SHARE_MMU);
> >   #else
> I think this is going in the wrong direction.  Why isn't the code just
> #if defined(SHM_SHARE_MMU)
>       /* use intimate shared memory on Solaris */
>       memAddress = shmat(shmid, 0, SHM_SHARE_MMU);
> #else
> If the symbol is available I think we probably want to use it.  It is an
> O/S issue, not a hardware issue, and so the test on __sparc__ seems
> quite wrongheaded ...

What I was hoping to do with the define test was to throw an error if we
don't find intimate shared memory on Solaris, but the define doesn't
work fir i386/Solaris so we are probably better going with the define as
you suggest --- I just hope we don't fail to include a file and somehow
miss it on some version of Solaris.

Change applied.

  Bruce Momjian                        |
  [EMAIL PROTECTED]               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
      joining column's datatypes do not match

Reply via email to