Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches
I will try to apply it within the next 48 hours. --------------------------------------------------------------------------- Gavin Sherry wrote: > On Thu, 31 Jul 2003, Tom Lane wrote: > > > Gavin Sherry <[EMAIL PROTECTED]> writes: > > > What are your feelings about numeric argument vs. int4/int8 arguments? > > > > Actually I think it'd be fine to take int8. We'd not be able to cope > > with any larger input anyway, and the inner loop could be noticeably > > faster if the control logic just deals with int. > > > > We could leave the factorial(numeric) case open for a future > > implementation that uses gamma, if anyone gets hot to do it. > > > > Attached is a revised patch based on your Tom's comments. It removes > int[248]fac(), modifies regression tests (which referenced int4fac()), and > implements a much cleaned numeric_fac(). > > > regards, tom lane > > > > Thanks, > > Gavin Content-Description: [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 2: you can get off all lists at once with the unregister command > (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED]) -- Bruce Momjian | http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 ---------------------------(end of broadcast)--------------------------- TIP 8: explain analyze is your friend