Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> example, we have *no* evidence to suggest that that NOFIXADE stuff in > >> main.c is needed on platforms that don't define __alpha. I would tend > >> to take an "if it ain't broke don't fix it" approach, especially on > >> platforms we don't have handy to test. > > > The problem was that certain cases tested for __alpha__ and some > > __alpha --- same with __sparc. > > My point is that without testing, you have no way to know that that > variation is not correct, and perhaps even necessary. Given that this > code has been through many releases already, I think the odds that you > are breaking something are higher than the odds that you are fixing > something. I think you should leave well enough alone until we get an > actual bug report showing that there's a problem.
OK, removed __alpha__ tests from main.c, and documented that they aren't being used, so we know it is a concious decision. I left the __alpha__ in s_lock.h because of course that is generic. -- Bruce Momjian | http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 ---------------------------(end of broadcast)--------------------------- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
