Ok, here's an updated timer.c that fixes these concerns and also adds a $postgresql$ header to the file.
It also removes the check if value == NULL, since that is now Asserted instead. And it really should never happen based on the places where setitimer is used. The patch stays unchanged, just a new timer.c //Magnus >-----Original Message----- >From: Claudio Natoli [mailto:[EMAIL PROTECTED] >Sent: den 17 februari 2004 12:25 >To: Magnus Hagander; [EMAIL PROTECTED]; >[EMAIL PROTECTED] >Subject: RE: [pgsql-hackers-win32] win32 setitimer implementation > > > > > >> Here is a patch that implements setitimer() on win32. With >this patch >> applied, deadlock detection and statement_timeout now works. >> >> The file timer.c goes into src/backend/port/win32/. > >Minor comments: > >* "timer.c" has shmem.c in header >* I'd suggest Asserts on the remaining 2 limitations ("zero" >it_interval and NULL ovalue), on the off chance that some >future change to the source expects them (ie. so we'll find >out about it under win32 pretty quickly); possibly provide >defines of ITIMER_VIRT and ITIMER_PROF, for completeness. > >Looks good, >Claudio > >--- >Certain disclaimers and policies apply to all email sent from >Memetrics. For the full text of these disclaimers and policies see ><a >href="http://www.memetrics.com/emailpolicy.html";>http://www.mem >etrics.com/em >ailpolicy.html</a> >
timer.c
Description: timer.c
---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?
http://archives.postgresql.org
