If that doesn't create any new warnings on the current (fixed) code, then I agree with this.
(Right, it does not.)
However, I'd like to see it factored more to avoid repeating it for jade and nsgmls. The warning flags are in fact SP flags, not Jade flags; only Jade is built on top of SP. So maybe assign this to SPFLAGS and add that to both invocations. (This is a bit analogous to CPPFLAGS vs. CFLAGS.)
Attached is a patch that does this.
-Neil
Index: doc/src/sgml/Makefile =================================================================== RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/Makefile,v retrieving revision 1.64 diff -c -r1.64 Makefile *** a/doc/src/sgml/Makefile 15 Jan 2004 23:51:32 -0000 1.64 --- b/doc/src/sgml/Makefile 29 Feb 2004 17:11:59 -0000 *************** *** 58,63 **** --- 58,65 ---- override JADEFLAGS += -V draft-mode endif + # Enable some extra warnings + override SPFLAGS += -wall -wno-unused-param -wno-empty ## ## Man pages *************** *** 86,92 **** html: postgres.sgml $(ALLSGML) stylesheet.dsl @rm -f *.html ! $(JADE) $(JADEFLAGS) $(SGMLINCLUDE) $(CATALOG) -d stylesheet.dsl -i output-html -t sgml $< ifeq ($(vpath_build), yes) @cp $(srcdir)/stylesheet.css . endif --- 88,94 ---- html: postgres.sgml $(ALLSGML) stylesheet.dsl @rm -f *.html ! $(JADE) $(JADEFLAGS) $(SPFLAGS) $(SGMLINCLUDE) $(CATALOG) -d stylesheet.dsl -i output-html -t sgml $< ifeq ($(vpath_build), yes) @cp $(srcdir)/stylesheet.css . endif *************** *** 220,226 **** # Quick syntax check without style processing check: postgres.sgml $(ALLSGML) ! $(NSGMLS) $(SGMLINCLUDE) -s $< ## --- 222,228 ---- # Quick syntax check without style processing check: postgres.sgml $(ALLSGML) ! $(NSGMLS) $(SPFLAGS) $(SGMLINCLUDE) -s $< ##
---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])
