The doc for the trim functions does not say that the second argument can 
be omitted. This patch fixes it. It also fixes that the type text was not 
wrapped as <type>text</type>.

I can not build the docs myself, but i'm pretty sure it's correct.

Is it okay to commit this? Should I do it on the 7.4 branch also, before
the release?

-- 
/Dennis Björklund
Index: func.sgml
===================================================================
RCS file: /cvsroot/pgsql-server/doc/src/sgml/func.sgml,v
retrieving revision 1.189
diff -u -r1.189 func.sgml
--- func.sgml   29 Feb 2004 15:45:53 -0000      1.189
+++ func.sgml   4 Mar 2004 18:03:18 -0000
@@ -1157,11 +1157,13 @@
       </row>
 
       <row>
-       <entry><literal><function>ltrim</function>(<parameter>string</parameter> 
<type>text</type>, <parameter>characters</parameter> 
<type>text</type>)</literal></entry>
+       <entry><literal><function>ltrim</function>(<parameter>string</parameter> 
<type>text</type>
+        <optional>, <parameter>characters</parameter> 
<type>text</type></optional>)</literal>
+       </entry>
        <entry><type>text</type></entry>
        <entry>
         Remove the longest string containing only characters from
-        <parameter>characters</parameter> from the start of
+        <parameter>characters</parameter> (a space by default) from the start of
         <parameter>string</parameter>.
        </entry>
        <entry><literal>ltrim('zzzytrim', 'xyz')</literal></entry>
@@ -1255,12 +1257,13 @@
       </row>
 
       <row>
-       <entry><literal><function>rtrim</function>(<parameter>string</parameter>
-        text, <parameter>characters</parameter> text)</literal></entry>
+       <entry><literal><function>rtrim</function>(<parameter>string</parameter> 
<type>text</type>
+        <optional>, <parameter>characters</parameter> 
<type>text</type></optional>)</literal>
+       </entry>
        <entry><type>text</type></entry>
        <entry>
         Remove the longest string containing only characters from
-        <parameter>characters</parameter> from the end of
+        <parameter>characters</parameter> (a space by default) from the end of
         <parameter>string</parameter>.
        </entry>
        <entry><literal>rtrim('trimxxxx', 'x')</literal></entry>
---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
      joining column's datatypes do not match

Reply via email to