Re: [PATCHES] Bug in CVS pg_dump against 7.0.x

[Christopher Kings-Lynne]

Duh, sorry.  Got confused.  I though you weren't the submitter, for some
strange reason.   Anyway, I see this in the code:

Advertising








+     /* Handle array types */
+     if (typname[0] == '_')
+     {
+             isarray = true;
+             typname++;
+     }

Do we know that is always true?  What is the issue that 7.0 needs this
and newer released don't, and how are we sure this will not break some
strange cases in post-7.0 releases?
It's not a problem, since that code path is only ever executed when 
dumping a 7.0 backend.  It's in the MyFormatType function in pg_dump.c 
that is used whenever the backend doesn't have its own format_type function.

Chris
---------------------------(end of broadcast)---------------------------
TIP 8: explain analyze is your friend