Tom Lane wrote: > Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > > This might seem a bit silly, but is there any chance we could add a > > comment at the end of pg_dump text output that says '-- End of dump'? > > Sure --- while you're at it, put a "beginning of dump" at the start. > > Is it worth adding the database name and/or other command-line > parameters given to pg_dump? > > One thing to think about is the difference between a bare pg_dump and a > pg_dump/pg_restore sequence. Should these always generate identical > text output? (They do as of CVS tip, I believe, though this was not > always true before.)
I have added code to print end-of-dump markers for pg_dump and pg_dumpall: -- -- PostgreSQL database dump complete -- -- -- PostgreSQL database cluster dump complete -- This mirrors the markers used at the start of the files. -- Bruce Momjian | http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
Index: src/bin/pg_dump/pg_backup_archiver.c =================================================================== RCS file: /cvsroot/pgsql-server/src/bin/pg_dump/pg_backup_archiver.c,v retrieving revision 1.86 diff -c -c -r1.86 pg_backup_archiver.c *** src/bin/pg_dump/pg_backup_archiver.c 22 Apr 2004 02:39:10 -0000 1.86 --- src/bin/pg_dump/pg_backup_archiver.c 19 May 2004 21:17:43 -0000 *************** *** 384,389 **** --- 384,391 ---- AH->blobConnection = NULL; } } + + ahprintf(AH, "--\n-- PostgreSQL database dump complete\n--\n\n"); } /* Index: src/bin/pg_dump/pg_dumpall.c =================================================================== RCS file: /cvsroot/pgsql-server/src/bin/pg_dump/pg_dumpall.c,v retrieving revision 1.33 diff -c -c -r1.33 pg_dumpall.c *** src/bin/pg_dump/pg_dumpall.c 14 May 2004 17:04:47 -0000 1.33 --- src/bin/pg_dump/pg_dumpall.c 19 May 2004 21:17:43 -0000 *************** *** 242,247 **** --- 242,252 ---- } PQfinish(conn); + + printf("--\n"); + printf("-- PostgreSQL database cluster dump complete\n"); + printf("--\n\n"); + exit(0); }
---------------------------(end of broadcast)--------------------------- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly