Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > The following patch addresses this issue by making libpgport usable > > unchanged by client applications, and makes a special server version for > > the backend. > > This raises some alarm bells for me. Why does a "port support" library > need to distinguish whether it is running in frontend or backend? > Certainly the standard Unix library calls that it is purporting to > replace do not care.
Already described --- ereport, memory allocation, and thread safety. > Also, the patch does both more and less than I'd expect from your > description. Why are there no changes at all to C code? And how can > you just remove, eg, dirmod.c and exec.c from pg_resetxlog? Basically libpgport now is compiled for the frontend so it just gets it from the link line rather than build its own. -- Bruce Momjian | http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 ---------------------------(end of broadcast)--------------------------- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html
