> Tom Lane wrote: > > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > > Incidentally ("collateral damage"), the patch modifies the TRUNCATE > > > command so that it can work on multiple tables. In particular, if > > > foreign key references are all internal to the group that's being > > > truncated, the command is allowed. > > > > I think this is a feature addition that you've cleverly managed to > > present as a bug fix ;-). While I like the feature, I've got very > > mixed emotions about applying it this late in beta.
Ok, you caught me :-) Actually, I developed the patch thinking only on the multi-relation TRUNCATE, with the goal of having it for 8.1. Only after I prepared a first patch I noticed the temp-table-FKs problem. So I don't really care if it has to wait for 8.1 because that was the original intention anyway. > > OTOH, multiple TRUNCATE would be a useful feature --- it came up > > just the other day. Right, that's why I did it in the first place. On Sat, Nov 06, 2004 at 12:56:24AM -0500, Bruce Momjian wrote: > Alvaro, would you post the patch skipping whitespace changes. As posted > the patch does look very large, as you suggested. Ok, turns out it wasn't that much smaller anyway :-) But really it's only stashing a couple of foreach loops in two places, which is a fairly trivial change; and the other important part is the modification of heap_truncate_check_FKs and it's fairly localized anyway. -- Alvaro Herrera (<alvherre[a]dcc.uchile.cl>) "Aprender sin pensar es inútil; pensar sin aprender, peligroso" (Confucio) ---------------------------(end of broadcast)--------------------------- TIP 6: Have you searched our list archives? http://archives.postgresql.org