On Sun, 2004-11-21 at 23:07, Simon Riggs wrote:
> I enclose a short patch to reduce the PGARCH_RESTART_INTERVAL from 60
> seconds to 10 seconds. The original number was plucked from thin air
> some months ago, and I'd like to review that now based upon further
> thought, observation and experience.
> 
> This change has little or no effect on performance, since the interval
> is there mainly to avoid repeated respawn attempts if archiver fails at
> startup. Archiver start-up time is very quick, so there is little danger
> of exceeding 10 seconds.
> 
> On a busy system, if the archiver does die, then many files can build up
> in the 60 seconds before respawning. That xlog file backlog could take
> some time to clear. This then leaves a larger than normal window of data
> loss for a possibly long period.
> 
> It's a minor change only, with no other effect on function.

...and now for the diff -c version.... ;-)

-- 
Best Regards, Simon Riggs
Index: pgarch.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/backend/postmaster/pgarch.c,v
retrieving revision 1.10
diff -d -c -r1.10 pgarch.c
*** pgarch.c	9 Nov 2004 13:01:26 -0000	1.10
--- pgarch.c	21 Nov 2004 22:59:03 -0000
***************
*** 51,57 ****
  #define PGARCH_AUTOWAKE_INTERVAL 60		/* How often to force a poll of
  										 * the archive status directory;
  										 * in seconds. */
! #define PGARCH_RESTART_INTERVAL 60		/* How often to attempt to restart
  										 * a failed archiver; in seconds. */
  
  /* ----------
--- 51,57 ----
  #define PGARCH_AUTOWAKE_INTERVAL 60		/* How often to force a poll of
  										 * the archive status directory;
  										 * in seconds. */
! #define PGARCH_RESTART_INTERVAL 10		/* How often to attempt to restart
  										 * a failed archiver; in seconds. */
  
  /* ----------
---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
      joining column's datatypes do not match

Reply via email to