On Mon, 2004-12-13 at 11:30 +0000, Dave Page wrote:
> > -----Original Message-----
> > From: Neil Conway [mailto:[EMAIL PROTECTED] 
> > Sent: 13 December 2004 03:59
> > To: Dave Page
> > Cc: pgsql-patches
> > Subject: RE: [PATCHES] pg_resetxlog as root
> > 
> > On Sun, 2004-12-12 at 23:59 +0000, Dave Page wrote:
> > > Sounds reasonable to me.
> > 
> > Attached is a patch that implements this.
> > src/port/backend/win32/security.c is moved to 
> > src/port/win32_security.c, and conditionally added to 
> > LIBOBJS. Note that I don't have much experience with the 
> > build system, and less still with the Win32 port, so please 
> > let me know if there's a better way to do this. Also, I don't 
> > have a Windows build environment -- could someone verify 
> > whether this builds on Win32?
> Not quite there I'm afraid. Unfortunately I don't have time right now to
> look further, but I don't suppose it's a major problem [...]

On closer inspection, there are other places where Win32 could make this
check but does not (e.g. pg_ctl, initdb). Therefore I've decided not to
fix the Win32 side of things, and just committed the patch as is. IMHO
it would be wise for the Win32 folks to fix this, but I'll leave that
decision to them (... without a Win32 build environment I'm not really
comfortable committing fixes during RC without being able to compile,
much less test them).


---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
      joining column's datatypes do not match

Reply via email to